Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding upgrade for pandas deprecation warning, adding pyarrow>=0.17.0… #1844

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

power-edge
Copy link

… at minimum requirement as defined in dev requirements for pandas==1.3.0 version

… at minimum requirement as defined in dev requirements for pandas==1.3.0 version
@power-edge
Copy link
Author

power-edge commented Jan 29, 2024

trying to get rid of a pandas deprecation warning. fixed up some tests that weren't working. adding requirements_dev for us (based on what else I was required to install to run tests). Please let me know if any of these "dev" requirements belong in the main requirements

@ValueRaider
Copy link
Collaborator

Why is pyarrow needed?

@power-edge
Copy link
Author

power-edge commented Jan 29, 2024

When I was running test, I saw this warning without pyarrow installed. This PR was to remove annoying pandas warnings, wdyt? I have removed it for now. I also dropped the requirements_dev.txt, on closer inspection those requirements were covered by the extras already.

Here is the warning I saw when running tests in some new virtual envs with project just installed.

./yfinance/yfinance/ticker.py:27: DeprecationWarning: 
  Pyarrow will become a required dependency of pandas in the next major release of pandas (pandas 3.0),
  (to allow more performant data types, such as the Arrow string type, and better interoperability with other libraries)
  but was not found to be installed on your system.
  If this would cause problems for you,
  please provide us feedback at https://github.com/pandas-dev/pandas/issues/54466
          
    import pandas as _pd

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

image

FYI I have tested these changes while trying to keep requirements down to a minimum version (replace >= with ~=) and the tests were passing in this state the same as with >=

@ValueRaider
Copy link
Collaborator

This one should be left for user & Pandas to handle.

@power-edge
Copy link
Author

it is removed

@ValueRaider ValueRaider merged commit 97f93d3 into ranaroussi:dev Jan 31, 2024
1 check passed
@ValueRaider ValueRaider mentioned this pull request Feb 4, 2024
@ValueRaider ValueRaider mentioned this pull request Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants